Ticket #2331 (closed enhancement: fixed)

Opened 5 years ago

Last modified 5 years ago

Support little-endian hexdump input for decode-dimms

Reported by: ticket Owned by: khali
Priority: minor Milestone:
Component: misc Version:
Keywords: decode-dimms Cc: paul@…

Description

Current version of decode-dimms has a command line -x switch to allow the program to interpret hexdump of SPD. Unfortunately, when it recognizes that hexdump has produced two-byte 'words' it assumes that the data is in big-endian format. Since some systems have little-endian format, it would be useful to support both formats. The attached patch accomplishes this by implementing a -X command line switch.

Note that it might be more logical to use a 'little-x' for little-endian vs. 'big-X' for big-endian but this would change the existing interface.

Attachments

decode-dimms.diff Download (1.8 KB) - added by ticket 5 years ago.
Patch to implement -X for little-endian hexdump
decode-dimms-little-endian-dump.patch Download (2.7 KB) - added by khali 5 years ago.
Updated patch adding support for little-endian word dumps

Change History

Changed 5 years ago by ticket

Patch to implement -X for little-endian hexdump

Changed 5 years ago by khali

  • owner changed from somebody to khali
  • status changed from new to assigned

Hi Paul, thanks for your contribution. I have polished your patch a little, I am attaching my updated version, please test it and report.

Changed 5 years ago by khali

Updated patch adding support for little-endian word dumps

Changed 5 years ago by ticket

Yup, your patch works just fine. Feel free to close the ticket.

Changed 5 years ago by khali

  • status changed from assigned to closed
  • resolution set to fixed

Implemented in r5287.

Note: See TracTickets for help on using tickets.