fancontrol script errors

[ticket]

After creating /etc/fancontrol using v 0.9 of pwmconfig I get following errors.

/sbin/fancontrol: line 98: [: : integer expression expected
/sbin/fancontrol: line 110: [: : integer expression expected
/sbin/fancontrol: line 116: [: : integer expression expected
.
.
.
Error in configuration file (hwmon0/device/pwm1):
MINSTOP must be greater than or equal to MINPWM

see attached file(s) with dialog of the pwmconfig, fancontrol, and the /etc/fanconfig file.

[ticket]

output from pwmconfig, followed by output from output from fancontrol, followed by /etc/fancontrol

[ticket]

your line numbers 147,148, and 149 show the bash script errors in fancontrol I've been able to get further by editing the file but will quit for now.

vince

[khali]

The errors in fancontrol are caused by a broken configuration file. I've made fancontrol a bit more robust to such configuration file errors (r5102), but it's difficult to cleanly catch all mistakes in a shell script.

Why your configuration file was broken, I can't tell. I couldn't reproduce the problem. Maybe there was garbage in your configuration file to start with and it confused pwmconfig. Does the problem still happen if you delete /etc/fancontrol before running pwmconfig?

[ticket]

I removed /etc/fancontrol, then installed the latest svn copy and used pwmconfig to re-build fancontrol. No more errors.

However. it appears I might have found another bug. if I let pwmconfig take the defaults for the prompts (eg, just hit enter):

Enter the minimum PWM value (0-255)
at which the fan STARTS spinning (press t to test) (150):

Enter the minimum PWM value (0-255)
at which the fan STOPS spinning (press t to test) (100):

then the resultant fancontrol file is:

INTERVAL=10
FCTEMPS=hwmon0/device/pwm1=hwmon0/device/temp2_input
FCFANS= hwmon0/device/pwm1=hwmon0/device/fan1_input
MINTEMP=hwmon0/device/pwm1=45
MAXTEMP=hwmon0/device/pwm1=55
MINSTART=hwmon0/device/pwm1=150
MINSTOP=hwmon0/device/pwm1=100

MISSING 
MINPWM=hwmon0/device/pwm1=100
MAXPWM=hwmon0/device/pwm1=255

[khali]

This is working as designed. MINPWM and MAXPWM are optional and default to 0 and 255, respectively, if not provided. pwmconfig does not write them to the configuration file if they have the default value. Just run fancontrol and it'll tell:

Settings for hwmon1/device/pwm1:
(...)
  MINPWM=0
  MAXPWM=255

So it is perfectly happy with these default values not being written to /etc/fancontrol.