Ticket #2230 (closed task: fixed)

Opened 7 years ago

Last modified 7 years ago

Clean up struct sensors_chip_name

Reported by: khali Owned by: khali
Priority: major Milestone: 3.0.0
Component: libsensors Version:
Keywords: Cc:

Description

In the new libsensors code, sensors_chip_name.busname is (ab)used to store the sysfs path to the sensor chip. This doesn't have much to do with a "bus name". At the very least we need a better name, but I am also wondering if we really want to expose this path to the user There might be no easy way around it though.

We also need to introduce a bus type field. For now, positive bus numbers are used for I2C buses, and negative values are used for other buses (PCI, LPC...). But other numbered buses need to be supported as well, like SPI. This means that we want separate struct fields for the bus type and the bus number.

I guess that we can get rid of the "dummy" bus type in the process; not sure what it was supposed to be.

Change History

Changed 7 years ago by khali

  • component changed from interface to libsensors

Changed 7 years ago by khali

  • owner changed from somebody to khali
  • status changed from new to assigned

Support for "dummy" bus type was dropped (r4672).

sensors_chip_name.busname was renamed to path (r4673).

Changed 7 years ago by khali

  • status changed from assigned to closed
  • resolution set to fixed

Bus type field added (r4686, r4687).

Note: See TracTickets for help on using tickets.