Ticket #2224 (closed enhancement: fixed)

Opened 6 years ago

Last modified 6 years ago

Fancontrol limit pwm decrease rate patch

Reported by: vincent.stehle@… Owned by: khali
Priority: minor Milestone: 2.10.4
Component: fancontrol Version:
Keywords: Cc:

Description

Hi,

Here is a proposed patch against fancontrol.pl to limit the pwm decrease rate. This, to limit the user noticing the noise change, while keeping good response to temp. rise. IMHO it does reduce the annoyance at full load.

Thanks for the good work on lm_sensors and fancontrol.

Best regards,

-- Vincent Stehlé, a happy user of lm_sensors/fancontrol.

Attachments

patch-fancontrol-vs.pl Download (2.1 KB) - added by ticket 6 years ago.
fancontrol-linear.patch Download (2.0 KB) - added by khali 6 years ago.
Use a linear interpolation formula instead of quadratic

Change History

Changed 6 years ago by ticket

Changed 6 years ago by khali

  • cc vincent.stehle@… removed
  • owner changed from somebody to khali
  • status changed from new to assigned
  • reporter changed from ticket to vincent.stehle@…

First of all, I'd like to get rid of fancontrol.pl. The bash variant of the script will be much improved in lm-sensors 2.10.4, so there is little reason in doubling the maintenance effort. If you want to work on something, please work on the latest version of fancontrol (the bash script).

Why are you changing the code responsible for restarting the fan? This shouldn't be needed. This functionality is not related to the standard fan speed computation and shouldn't be affected by the regulation policy.

In the leading comment of you patch, you write: "temperature values reported by the sensors can be very noisy". Are they? Mine are quite stable and reliable. If the temperature is not reported properly, then using it to control the fan speed automatically is probably not a good idea to start with.

You also write: "pwm values follow a quadratic reaction". This is true, but I am wondering why it is so. The documentation states: "Currently the speed increases quadratically with rising temperature. This way you won't hear your fans most of the time at best." This doesn't sound like a good reason. If the goal is to not hear the fan most of the time, then a thermostatic (or near-thermostatic) approach is better, and the new version of fancontrol makes this possible. On my system, I've changed the formula to be linear instead of quadratic, and it tends to work better. So if it helps you too, I'd rather just do that than making the script more complex. I'll attach a patch.

Changed 6 years ago by khali

Use a linear interpolation formula instead of quadratic

Changed 6 years ago by khali

  • milestone set to 2.10.4

Changed 6 years ago by khali

  • status changed from assigned to closed
  • resolution set to fixed

Patch applied to SVN (changeset r4588).

Changed 6 years ago by khali

  • keywords fancontrol removed
  • component changed from misc to fancontrol
Note: See TracTickets for help on using tickets.