Changeset 941

Timestamp:

12/02/00 23:39:21 (12 years ago)

Author:

mds

Message:

(mds) Add "dummy writes" before bit reads as recommended in 815

programmers' reference guide. This ensures that the input value
is latched in the 815 register. We assume this also applies
to the 810 or at least does no harm. Ticket 419.
Alan Chen <alp_chen@…> reports that this fixes the
bug where i2c-algo-bit bit_test=1 fails the test.
We don't have any data that shows there was any problem in
normal operation (non bit_test) or that this fixes anything else.

Location:

lm-sensors/trunk

Files:

• CHANGES (modified) (1 diff)
• kernel/busses/i2c-i810.c (modified) (4 diffs)

lm-sensors/trunk/CHANGES

@@ -28 +28 @@
   Module ds1621: new
   Module i2c-ali1535: Enhance error checking and recovery; add mutex
+  Module i2c-i810: Add "dummy write" before reads per Intel prog. ref.
   Module lm87: update voltage calculations
   Module mtp008: new

lm-sensors/trunk/kernel/busses/i2c-i810.c

@@ -134 +134 @@
 /* The GPIO pins are open drain, so the pins always remain outputs.
    We rely on the i2c-algo-bit routines to set the pins high before
-   reading the input from other chips. */
+   reading the input from other chips. Following guidance in the 815
+   prog. ref. guide, we do a "dummy write" of 0 to the register before
+   reading which forces the input value to be latched. We presume this
+   applies to the 810 as well. This is necessary to get
+   i2c_algo_bit bit_test=1 to pass. */
 
 static int bit_i810i2c_getscl(void *data)
 {
+        outlong(0, I810_GPIOB);
         return (0 != (readlong(I810_GPIOB) & SCL_VAL_IN));
 }
@@ -143 +148 @@
 static int bit_i810i2c_getsda(void *data)
 {
+        outlong(0, I810_GPIOB);
         return (0 != (readlong(I810_GPIOB) & SDA_VAL_IN));
 }
@@ -160 +166 @@
 static int bit_i810ddc_getscl(void *data)
 {
+        outlong(0, I810_GPIOA);
         return (0 != (readlong(I810_GPIOA) & SCL_VAL_IN));
 }
@@ -165 +172 @@
 static int bit_i810ddc_getsda(void *data)
 {
+        outlong(0, I810_GPIOA);
         return (0 != (readlong(I810_GPIOA) & SDA_VAL_IN));
 }