Changeset 5691

Timestamp:

03/20/09 15:08:43 (4 years ago)

Author:

khali

Message:

Don't call an external tool (ls) to get the list of dimms. Using
opendir() is more efficient and more flexible.

Files:

• i2c-tools/trunk/eeprom/decode-dimms (modified) (2 diffs)

i2c-tools/trunk/eeprom/decode-dimms

@@ -1616 +1616 @@
 sub get_dimm_list
 {
-        my $dir;
+        my ($dir, $file, @files);
 
         if ($use_sysfs) {
@@ -1624 +1624 @@
         }
 
-        if (-d $dir) {
-                return split(/\s+/, `ls $dir`);
+        if (opendir(local *DIR, $dir)) {
+                while (defined($file = readdir(DIR))) {
+                        next if $file =~ m/^\./;
+                        push @files, $file;
+                }
+                close(DIR);
+                return sort @files;
         } elsif (! -d '/sys/module/eeprom') {
                 print "No EEPROM found, are you sure the eeprom module is loaded?\n";