Changeset 5565

Show
Ignore:
Timestamp:
12/14/08 19:13:22 (4 years ago)
Author:
khali
Message:

Fix obvious decoding logic bug in decode_sdr_sdram().

Location:
lm-sensors/trunk
Files:
2 modified

Legend:

Unmodified
Added
Removed

  • lm-sensors/trunk/CHANGES

    r5564 r5565  
    1919  Module max1619: Use inline functions instead of macros (2.6 backport) 
    2020  Program decode-dimms.pl: Only export the ceil function from POSIX  
     21                           Fix decoding of SDR SDRAM bytes 12-14 
    2122  Program pwmconfig: Fix MINSTOP and MINSTART test functions (#2340) 
    2223                     Change default for MINTEMP from 0 to 20 degrees C 

  • lm-sensors/trunk/prog/eeprom/decode-dimms.pl

    r5537 r5565  
    533533 
    534534        $l = "Refresh Type"; 
    535         if ($bytes->[12] > 126) { printl $l, "Self Refreshing"; } 
     535        if ($bytes->[12] & 0x80) { printl $l, "Self Refreshing"; } 
    536536        else { printl $l, "Not Self Refreshing"; } 
    537537 
    … …  
    547547 
    548548        $l = "Primary SDRAM Component Bank Config"; 
    549         if ($bytes->[13] > 126) { printl $l, "Bank2 = 2 x Bank1"; } 
     549        if ($bytes->[13] & 0x80) { printl $l, "Bank2 = 2 x Bank1"; } 
    550550        else { printl $l, "No Bank2 OR Bank2 = Bank1 width"; } 
    551551 
    … …  
    556556 
    557557        $l = "Error Checking SDRAM Component Bank Config"; 
    558         if ($bytes->[14] > 126) { printl $l, "Bank2 = 2 x Bank1"; } 
     558        if ($bytes->[14] & 0x80) { printl $l, "Bank2 = 2 x Bank1"; } 
    559559        else { printl $l, "No Bank2 OR Bank2 = Bank1 width"; } 
    560560