Changeset 5560

Show
Ignore:
Timestamp:
12/11/08 17:23:46 (4 years ago)
Author:
khali
Message:

Fix obvious decoding logic bug in decode_sdr_sdram().

Files:
1 modified

Legend:

Unmodified
Added
Removed

  • i2c-tools/trunk/eeprom/decode-dimms

    r5559 r5560  
    524524        printl("Module Configuration Type", $temp); 
    525525 
    526         if ($bytes->[12] > 126) { $temp = "Self Refreshing"; } 
     526        if ($bytes->[12] & 0x80) { $temp = "Self Refreshing"; } 
    527527        else { $temp = "Not Self Refreshing"; } 
    528528        printl("Refresh Type", $temp); 
    … …  
    538538        printl("Refresh Rate", $temp); 
    539539 
    540         if ($bytes->[13] > 126) { $temp = "Bank2 = 2 x Bank1"; } 
     540        if ($bytes->[13] & 0x80) { $temp = "Bank2 = 2 x Bank1"; } 
    541541        else { $temp = "No Bank2 OR Bank2 = Bank1 width"; } 
    542542        printl("Primary SDRAM Component Bank Config", $temp); 
    … …  
    544544               value_or_undefined($bytes->[13] & 0x7f)); 
    545545 
    546         if ($bytes->[14] > 126) { $temp = "Bank2 = 2 x Bank1"; } 
     546        if ($bytes->[14] & 0x80) { $temp = "Bank2 = 2 x Bank1"; } 
    547547        else { $temp = "No Bank2 OR Bank2 = Bank1 width"; } 
    548548        printl("Error Checking SDRAM Component Bank Config", $temp);