Changeset 5324

Timestamp:

09/08/08 15:51:22 (5 years ago)

Author:

khali

Message:

Use the same step values for the MINSTOP test as we do for the detailed
correlation. That is, 15 above 31 and 2 below 31. This makes more sense
than using 10 all the time, as changes in low PWM values tend to have a
greater effect on fan speeds than changes in high PWM values.

Location:

lm-sensors/branches/lm-sensors-3.0.0

Files:

• CHANGES (modified) (1 diff)
• prog/pwm/pwmconfig (modified) (3 diffs)

lm-sensors/branches/lm-sensors-3.0.0/CHANGES

@@ -8 +8 @@
              Fix MINSTOP and MINSTART test functions
              Test MINSTOP before MINSTART
+             Use better step values for MINSTOP test
   sensors-detect: Add Intel SCH (bus) support
                   Add SMSC EMC6D103 support

lm-sensors/branches/lm-sensors-3.0.0/prog/pwm/pwmconfig

@@ -607 +607 @@
 {
         echo
-        echo 'Now we decrease the PWM value in 10-unit-steps.'
-        echo 'Let the fan reach full speed, then press return until the'
-        echo "fan stops spinning. Then enter 'y'."
-        echo 'We will use this value +20 as the minimum speed.'
+        echo 'Now we decrease the PWM value to figure out the lowest usable value.'
+        echo 'Press return as long as the fan spins. When the fan stops spinning,'
+        echo "enter 'y'. We will use a slightly greater value as the minimum speed."
         let fanok=0
         let fanval=$MAX
@@ -617 +616 @@
         until [ "$fanok" = "1" ]
         do
-                let fanval=fanval-10
+                if [ $fanval -lt $STEP2_BELOW ]
+                then
+                        let fanval=$fanval-$STEP2
+                else
+                        let fanval=$fanval-$STEP
+                fi
                 if [ $fanval -lt 0 ] ; then let fanval=0 ; let fanok=1 ; fi
                 echo -n "Setting $pwms to $fanval..."
@@ -626 +630 @@
         pwmdisable $pwms
 
-        let fanval=fanval+20
-        if [ $fanval -gt $MAX ] ; then let fanval=$MAX ; fi
+        if [ $fanval -lt $STEP2_BELOW ]
+        then
+                let 'fanval=fanval+2*STEP2'
+        else
+                let 'fanval=fanval+STEP'
+        fi
         echo "OK, using $fanval"
 }