Changeset 5160

Show
Ignore:
Timestamp:
03/24/08 16:28:25 (5 years ago)
Author:
khali
Message:

Drop $opt_body, name was confusing and we can easily do without it.
Update header comment, drop redundant command line interface documentation.

Location:
i2c-tools/trunk
Files:
2 modified

Legend:

Unmodified
Added
Removed

  • i2c-tools/trunk/CHANGES

    r5157 r5160  
    88                Decode all DDR2 SDRAM timing information 
    99                Add support for reading SPD data from hexdumps 
     10                Make command line parsing more robust 
    1011  decode-vaio: Private data might not be readable by non-root users 
    1112               Print the asset tag 

  • i2c-tools/trunk/eeprom/decode-dimms.pl

    r5159 r5160  
    2323# 
    2424# 
    25 # The eeprom driver must be loaded. For kernels older than 2.6.0, the 
    26 # eeprom driver can be found in the lm-sensors package. 
    27 # 
    28 # use the following command line switches 
    29 #  -f, --format            print nice html output 
    30 #  -b, --bodyonly          don't print html header 
    31 #                          (useful for postprocessing the output) 
    32 #  -c, --checksum          decode completely even if checksum fails 
    33 #  -h, --help              display this usage summary 
     25# The eeprom driver must be loaded (unless option -x is used). For kernels 
     26# older than 2.6.0, the eeprom driver can be found in the lm-sensors package. 
    3427# 
    3528# References: 
    … …  
    4740use POSIX; 
    4841use Fcntl qw(:DEFAULT :seek); 
    49 use vars qw($opt_html $opt_body $opt_bodyonly $opt_igncheck $use_sysfs $use_hexdump 
     42use vars qw($opt_html $opt_bodyonly $opt_igncheck $use_sysfs $use_hexdump 
    5043            @vendors %decode_callback $revision @dimm_list); 
    5144 
    … …  
    12211214        push @dimm_list, $_ if $use_hexdump; 
    12221215} 
    1223 $opt_body = $opt_html && ! $opt_bodyonly; 
    1224  
    1225 if ($opt_body) { 
     1216 
     1217if ($opt_html && !$opt_bodyonly) { 
    12261218        print "<!DOCTYPE html PUBLIC \"-//W3C//DTD HTML 3.2 Final//EN\">\n", 
    12271219              "<html><head>\n", 
    … …  
    12341226printh 'Memory Serial Presence Detect Decoder', 
    12351227'By Philip Edelbrock, Christian Zuckschwerdt, Burkart Lingner, 
    1236 Jean Delvare and others'; 
     1228Jean Delvare, Trent Piepho and others'; 
    12371229 
    12381230 
    … …  
    14021394printl2 "\n\nNumber of SDRAM DIMMs detected and decoded", $dimm_count; 
    14031395 
    1404 print "</body></html>\n" if $opt_body; 
     1396print "</body></html>\n" if ($opt_html && !$opt_bodyonly);