Changeset 4825

Timestamp:

09/20/07 23:22:42 (6 years ago)

Author:

khali

Message:

Restore support for alarms.

Location:

lm-sensors/branches/lm-sensors-3.0.0/prog/sensord

Files:

• chips.c (modified) (5 diffs)
• sense.c (modified) (2 diffs)
• sensord.h (modified) (2 diffs)

lm-sensors/branches/lm-sensors-3.0.0/prog/sensord/chips.c

@@ -192 +192 @@
   /* terminate the list */
   voltage->dataNumbers[pos] = -1;
+
+  /* alarm if applicable */
+  if (IN_FEATURE(SENSORS_FEATURE_IN_ALARM)) {
+    voltage->alarmNumber = IN_FEATURE_NR(SENSORS_FEATURE_IN_ALARM);
+  } else if (IN_FEATURE(SENSORS_FEATURE_IN_MIN_ALARM)) {
+    voltage->alarmNumber = IN_FEATURE_NR(SENSORS_FEATURE_IN_MIN_ALARM);
+  } else if (IN_FEATURE(SENSORS_FEATURE_IN_MAX_ALARM)) {
+    voltage->alarmNumber = IN_FEATURE_NR(SENSORS_FEATURE_IN_MAX_ALARM);
+  } else {
+    voltage->alarmNumber = -1;
+  }
+  /* beep support missing for now */
+  voltage->beepNumber = -1;
 }
 
@@ -228 +241 @@
   /* terminate the list */
   temperature->dataNumbers[pos] = -1;
+
+  /* alarm if applicable */
+  if (TEMP_FEATURE(SENSORS_FEATURE_TEMP_ALARM)) {
+    temperature->alarmNumber = TEMP_FEATURE_NR(SENSORS_FEATURE_TEMP_ALARM);
+  } else if (TEMP_FEATURE(SENSORS_FEATURE_TEMP_MAX_ALARM)) {
+    temperature->alarmNumber = TEMP_FEATURE_NR(SENSORS_FEATURE_TEMP_MAX_ALARM);
+  } else {
+    temperature->alarmNumber = -1;
+  }
+  /* beep support missing for now */
+  temperature->beepNumber = -1;
 }
 
@@ -262 +286 @@
   /* terminate the list */
   fan->dataNumbers[pos] = -1;
+
+  /* alarm if applicable */
+  if (FAN_FEATURE(SENSORS_FEATURE_FAN_ALARM)) {
+    fan->alarmNumber = FAN_FEATURE_NR(SENSORS_FEATURE_FAN_ALARM);
+  } else {
+    fan->alarmNumber = -1;
+  }
+  /* beep support missing for now */
+  fan->beepNumber = -1;
 }
 
@@ -270 +303 @@
   vid->rrd = rrdF3;
   vid->type = DataType_voltage;
+  vid->alarmNumber = -1;
+  vid->beepNumber = -1;
   vid->dataNumbers[0] = feature->number;
   vid->dataNumbers[1] = -1;
@@ -280 +315 @@
   beepen->rrd = rrdF0;
   beepen->type = DataType_other;
+  beepen->alarmNumber = -1;
+  beepen->beepNumber = -1;
   beepen->dataNumbers[0] = feature->number;
   beepen->dataNumbers[1] = -1;

lm-sensors/branches/lm-sensors-3.0.0/prog/sensord/sense.c

@@ -77 +77 @@
 (const sensors_chip_name *chip, const ChipDescriptor *descriptor, int action) {
   const FeatureDescriptor *features = descriptor->features;
-  int alarms = 0, beeps = 0;
   int index0, subindex;
   int ret = 0;
@@ -84 +83 @@
   if (action == DO_READ)
     ret = idChip (chip);
-  if (!ret && descriptor->alarmNumber) {
-    if ((ret = sensors_get_value (chip, descriptor->alarmNumber, &tmp))) {
-      sensorLog (LOG_ERR, "Error getting sensor data: %s/#%d: %s", chip->prefix, descriptor->alarmNumber, sensors_strerror (ret));
-      ret = 20;
-    } else {
-      alarms = (int) (tmp + 0.5);
-    }
-  }
-  if (!ret && descriptor->beepNumber) {
-    if ((ret = sensors_get_value (chip, descriptor->beepNumber, &tmp))) {
-      sensorLog (LOG_ERR, "Error getting sensor data: %s/#%d: %s", chip->prefix, descriptor->beepNumber, sensors_strerror (ret));
-      ret = 21;
-    } else {
-      beeps = (int) (tmp + 0.5);
-    }
-  }
   for (index0 = 0; (ret == 0) && features[index0].format; ++ index0) {
     const FeatureDescriptor *feature = features + index0;
     int labelNumber = feature->dataNumbers[0];
-    int alarm = alarms & feature->alarmMask;
-    int beep = beeps & feature->beepMask;
+    int alarm, beep;
     char *label = NULL;
 
-    if ((action == DO_SCAN) && !alarm) {
-      continue;
-    } else if (!(label = sensors_get_label (chip, labelNumber))) {
+    if (!(label = sensors_get_label (chip, labelNumber))) {
       sensorLog (LOG_ERR, "Error getting sensor label: %s/#%d", chip->prefix, labelNumber);
       ret = 22;
     } else {
       double values[MAX_DATA];
+
+      alarm = 0;
+      if (!ret && feature->alarmNumber != -1) {
+        if ((ret = sensors_get_value (chip, feature->alarmNumber, &tmp))) {
+          sensorLog (LOG_ERR, "Error getting sensor data: %s/#%d: %s", chip->prefix, feature->alarmNumber, sensors_strerror (ret));
+          ret = 20;
+        } else {
+          alarm = (int) (tmp + 0.5);
+        }
+      }
+      if ((action == DO_SCAN) && !alarm)
+        continue;
+
+      beep = 0;
+      if (!ret && feature->beepNumber != -1) {
+        if ((ret = sensors_get_value (chip, feature->beepNumber, &tmp))) {
+          sensorLog (LOG_ERR, "Error getting sensor data: %s/#%d: %s", chip->prefix, feature->beepNumber, sensors_strerror (ret));
+          ret = 21;
+        } else {
+          beep = (int) (tmp + 0.5);
+        }
+      }
 
       for (subindex = 0; !ret && (feature->dataNumbers[subindex] >= 0); ++ subindex) {

lm-sensors/branches/lm-sensors-3.0.0/prog/sensord/sensord.h

@@ -90 +90 @@
   RRDFN rrd;
   DataType type;
-  int alarmMask;
-  int beepMask;
+  int alarmNumber;
+  int beepNumber;
   int dataNumbers[MAX_DATA + 1]; /* First entry is used for the label */
 } FeatureDescriptor;
@@ -97 +97 @@
 typedef struct {
   FeatureDescriptor *features;
-  int alarmNumber;
-  int beepNumber;
 } ChipDescriptor;