Changeset 4727

Timestamp:

08/26/07 23:20:55 (6 years ago)

Author:

khali

Message:

Fix a memory leak on error when printing an unknown chip.

Location:

lm-sensors/trunk

Files:

• CHANGES (modified) (1 diff)
• prog/sensors/chips.c (modified) (1 diff)

lm-sensors/trunk/CHANGES

@@ -9 +9 @@
   Module i2c-piix4: Add ATI SB700 support (2.6 backport)
   Module lm93: Fix an array overrun (2.6 backport)
+  Program sensors: Fix a memory leak on error (with -u)
   Program sensors-detect: Don't probe i2c-isa as a regular i2c bus
                           Add Winbond W83L786NR/NG/R/G detection

lm-sensors/trunk/prog/sensors/chips.c

@@ -6269 +6269 @@
       continue;
     }
-    if (! valid)
+    if (!valid) {
+      free(label);
       continue;
+    }
     if (data->mode & SENSORS_MODE_R) {
-      if(sensors_get_feature(*name,data->number,&val)) {
+      if(sensors_get_feature(*name,data->number,&val))
         printf("ERROR: Can't get feature `%s' data!\n",data->name);
-        continue;
-      }
-      if (data->mapping != SENSORS_NO_MAPPING)
+      else if (data->mapping != SENSORS_NO_MAPPING)
         printf("  %s: %.2f (%s)\n",label,val,data->name);
       else