Changeset 4436

Timestamp:

06/10/07 10:05:18 (6 years ago)

Author:

khali

Message:

Cleanups to fancontrol:
* Use let for arithmetic evaluation. Patch taken from the Suse package.
* Kill old commented-out code.

Location:

lm-sensors/trunk

Files:

• CHANGES (modified) (1 diff)
• prog/pwm/fancontrol (modified) (5 diffs)

lm-sensors/trunk/CHANGES

@@ -15 +15 @@
   Program isadump: Detect when address bit 7 is a busy flag
                    Fix Super-I/O exit sequence for Winbond/Fintek chips
+  Program fancontrol: Use let for arithmetic evaluation
   Program pwmconfig: Use smaller steps for low PWM values
   Program rrd: Support non-i2c devices (hwmon class)

lm-sensors/trunk/prog/pwm/fancontrol

@@ -3 +3 @@
 # Simple script implementing a temperature dependent fan speed control
 #
-# Version 0.63
+# Version 0.64
 #
 # Usage: fancontrol [CONFIGFILE]
@@ -189 +189 @@
                 pwmo=${AFCPWM[$fcvcount]}
                 pwmdisable $pwmo
-                fcvcount=$fcvcount+1
+                let fcvcount=$fcvcount+1
         done
         echo 'Verify fans have returned to full speed'
@@ -288 +288 @@
                         echo "new pwmval=$pwmval"
                 fi
-                fcvcount=$fcvcount+1
+                let fcvcount=$fcvcount+1
         done
 }
@@ -303 +303 @@
                 restorefans
         fi
-        fcvcount=$fcvcount+1
+        let fcvcount=$fcvcount+1
 done
 
@@ -314 +314 @@
         sleep $INTERVAL
 done
-
-# some old stuff/missing features, will clean this up soon
-#if ( test "$regulationtype" = "quad" ) ; then
-#  while true ; do
-#    temp=`cat ${temp1} | cut -b 12-13`
-#    if (( ${temp} < ${mintemp} )) ;
-#       then pwm=0
-#    elif (( ${temp} > ${maxtemp} )) ;
-#       then pwm=255
-#    else
-#       pwm=`calc "((10/(${maxtemp}-${mintemp})*(${temp}-${mintemp}))^2/1000*(${maxtemp}-${mintemp})*(255-${minspeed})+${minspeed})"`
-#       #no optimization here for readability (or sloth :))
-#    fi ;
-#    echo $pwm > ${pwm1} ;
-#
-#    sleep 10 ;
-#  done ;
-
-#elif ( test "$regulationtype" = "exp" ) ; then
-  #add support for exponential calculation here
-
-#else
-#  pwmconst=$[(255-${minspeed})/(${maxtemp}-${mintemp})]
-#  while true ; do
-#    let temp=`cat temp1 | cut -b 12-13` ;
-#    if (( ${temp} < ${mintemp} )) ;
-#        then pwm=0
-#    elif (( ${temp} > ${maxtemp} )) ;
-#        then pwm=255
-#    else
-#       pwm=$[(${temp}-${mintemp})*${pwmconst}+${minspeed}]
-#    fi ;
-#    echo $pwm > pwm2 ;
-#
-#    sleep 10 ;
-#  done ;
-#fi