Changeset 4094

Timestamp:

08/12/06 23:02:54 (7 years ago)

Author:

khali

Message:

Rewrite the bank switching code in a slightly different way to keep
some compilers quiet.

Files:

• lm-sensors/trunk/prog/dump/i2cdump.c (modified) (1 diff)

lm-sensors/trunk/prog/dump/i2cdump.c

@@ -291 +291 @@
         /* See Winbond w83781d data sheet for bank details */
         if (bank && size != I2C_SMBUS_BLOCK_DATA) {
-                old_bank = i2c_smbus_read_byte_data(file, bankreg);
-                if (old_bank >= 0)
+                res = i2c_smbus_read_byte_data(file, bankreg);
+                if (res >= 0) {
+                        old_bank = res;
                         res = i2c_smbus_write_byte_data(file, bankreg,
                                 bank | (old_bank & 0xf0));
-                if (old_bank < 0 || res < 0) {
+                }
+                if (res < 0) {
                         fprintf(stderr, "Error: Bank switching failed\n");
                         exit(1);