Changeset 4022

Timestamp:

01/07/06 18:19:24 (7 years ago)

Author:

khali

Message:

Drop i2c-dev's empty command implementation. This is a backport
from Linux 2.6, original patch from Laurent Riffard. Also update the
documentation not to suggest an empty implementation of command.

Location:

i2c/trunk

Files:

• CHANGES (modified) (2 diffs)
• doc/writing-clients (modified) (1 diff)
• kernel/i2c-dev.c (modified) (2 diffs)

i2c/trunk/CHANGES

@@ -22 +22 @@
                      Iwamoto)
   doc/writing-clients: New memory allocation model
+                       Drop empty command implementation example
   i2c-core: Fix logic error in SMBus Write Word transaction with software
             PEC (Hideki Iwamoto)
@@ -30 +31 @@
             Rewrite software PEC implementation (2.6 backport)
             Improve debugging in i2c_transfer (2.6 backport)
+  i2c-dev: Drop empty command implementation (2.6 backport, Laurent Riffard)
   i2c.h: Fix union i2c_smbus_data definition
          Delete 2 out-of-date, colliding ioctl defines

i2c/trunk/doc/writing-clients

@@ -658 +658 @@
 need this. You may even set it to NULL.
 
-  /* No commands defined */
-  int foo_command(struct i2c_client *client, unsigned int cmd, void *arg)
-  {
-    return 0;
-  }
-
 
 Sending and receiving

i2c/trunk/kernel/i2c-dev.c

@@ -89 +89 @@
         .attach_adapter = i2cdev_attach_adapter,
         .detach_client  = i2cdev_detach_client,
-        .command        = i2cdev_command,
 };
 
@@ -464 +463 @@
 }
 
-static int i2cdev_command(struct i2c_client *client, unsigned int cmd,
-                           void *arg)
-{
-        return -1;
-}
-
 static int __init i2c_dev_init(void)
 {