Changeset 2788

Timestamp:

12/07/04 16:32:19 (9 years ago)

Author:

mds

Message:

fix lm93_read_block which was retrying even on success.

Location:

lm-sensors/trunk

Files:

• CHANGES (modified) (1 diff)
• kernel/chips/lm93.c (modified) (2 diffs)

lm-sensors/trunk/CHANGES

@@ -46 +46 @@
                Knierim)
                Fix compilation breaking C99-ism (Axel Thimm)
+               Fix block read retries
   Module pc87360: Support secondary Super-I/O address
   Module smsc47m1: Add support for 47M15x and 47M192 (fans only)
   Library: Add lm63 support
            Add lpc47b397 support
+  Programs *.init: Rename lockfile to match file name
   Programs i2cset, isaset: Written byte/word can be masked
   Program decode-vaio.pl: Find eeproms on non-0 i2c bus too

lm-sensors/trunk/kernel/chips/lm93.c

@@ -445 +445 @@
 static void lm93_read_block(struct i2c_client *client, u8 fbn, u8 *values)
 {
-        int i, result;
+        int i, result=0;
 
         for (i = 1; i <= MAX_RETRIES; i++) {
@@ -451 +451 @@
                         lm93_block_read_cmds[fbn].cmd, lm93_block_buffer);
 
-                if (result != lm93_block_read_cmds[fbn].len) {
+                if (result == lm93_block_read_cmds[fbn].len) {
+                        break;
+                } else {
                         printk(KERN_WARNING "lm93.o: block read data failed, "
                                 "command 0x%02x.\n",