Context Navigation

← Previous Changeset
Next Changeset →

Changeset 2189

Timestamp:

12/24/03 00:13:38 (9 years ago)

Author:

mds

Message:

remove -o and -g args to install

Date: Thu, 18 Dec 2003 22:42:36 +0100
From: Haakon Riiser <haakon.riiser@…>
To: sensors@…
Subject: lm_sensors 2.8.2 / DESTDIR / root

The reason for this email is that I always try to avoid running
Makefiles as root, even during 'make install'. Therefore, I
always use the DESTDIR feature, when it's available. Until today,
I always built i2c and lm_sensors by doing

$ make
$ make -i install DESTDIR=/foo
$ cd /foo && su root && fix permissions/ownership && install

The -i flag to make install is a kludge to avoid having to be root
while installing to the DESTDIR, and it's only required because
the files are installed with "-o root -g root". Using the -i
flag is of course not a good idea, since more fatal errors can
easily fly by undetected.

Today, I upgraded to Linux 2.6.0, and tried a similar install
procedure for lm_sensors, except that the make target is now "user"
and the install target is "user_install". I now noticed that the
DESTDIR variable is not used everywhere in "user_install", so I
couldn't use the -i kludge anymore. Instead, I wrote a patch that
removes the "-o root -g root" arguments to install everywhere, and
I also tried to add DESTDIR to all files/directories installed.
(The patch only applies to lm_sensors, not i2c, since only
lm_sensors is required in Linux 2.6.0.)

There's really no reason to say -o root -g root anyway, since if you
do install directly with make install, you have to be logged in as
root, and then the files will get the right ownership by default.
Much of the point of installing to a temporary DESTDIR is that you
don't have to be root, and that you can prepare the installation
by hand. Fixing the ownership is trivial:

chown -R root.root $DESTDIR

Location:

lm-sensors/trunk

Files:

: 13 modified

Makefile (modified) (1 diff)
etc/Module.mk (modified) (1 diff)
kernel/busses/Module.mk (modified) (1 diff)
kernel/chips/Module.mk (modified) (1 diff)
kernel/include/Module.mk (modified) (1 diff)
lib/Module.mk (modified) (2 diffs)
prog/detect/Module.mk (modified) (1 diff)
prog/dump/Module.mk (modified) (1 diff)
prog/eeprom/Module.mk (modified) (1 diff)
prog/pwm/Module.mk (modified) (1 diff)
prog/sensord/Module.mk (modified) (1 diff)
prog/sensors/Module.mk (modified) (1 diff)
prog/xeon/Module.mk (modified) (1 diff)

Legend:

: Unmodified
: Added
: Removed

lm-sensors/trunk/Makefile

r2179	r2189
122	122	MANDIR := $(PREFIX)/man
123	123
124		~~# You should not need to change this. It defines the manual owner and group~~
125		~~# as which manual pages are installed.~~
126		~~MANOWN := root~~
127		~~MANGRP := root~~
128
129	124	MACHINE := $(shell uname -m)
130	125

lm-sensors/trunk/etc/Module.mk

r1822	r2189
30	30	$(MKDIR) $(DESTDIR)$(ETCDIR)
31	31	if [ ! -e $(DESTDIR)$(ETCINSTALL) ] ; then \
32		$(INSTALL) -~~o root -g root -~~m 644 $(ETCTARGET) $(DESTDIR)$(ETCINSTALL); \
	32	$(INSTALL) -m 644 $(ETCTARGET) $(DESTDIR)$(ETCINSTALL); \
33	33	fi
34	34	user_install :: install-etc

lm-sensors/trunk/kernel/busses/Module.mk

r1787	r2189
106	106	if [ -n "$(KERNELBUSSESTARGETS)" ] ; then \
107	107	$(MKDIR) $(DESTDIR)$(MODPREF)/kernel/drivers/i2c/busses ; \
108		$(INSTALL) -~~o root -g root -~~m 644 $(KERNELBUSSESTARGETS) $(DESTDIR)$(MODPREF)/kernel/drivers/i2c/busses ; \
	108	$(INSTALL) -m 644 $(KERNELBUSSESTARGETS) $(DESTDIR)$(MODPREF)/kernel/drivers/i2c/busses ; \
109	109	for i in $(KERNELBUSSESTARGETS) ; do \
110	110	$(RM) $(DESTDIR)$(MODPREF)/misc/`basename $$i` $(DESTDIR)$(MODPREF)/kernel/drivers/i2c/`basename $$i` \

lm-sensors/trunk/kernel/chips/Module.mk

r2174	r2189
161	161	if [ -n "$(KERNELCHIPSTARGETS)" ] ; then \
162	162	$(MKDIR) $(DESTDIR)$(MODPREF)/kernel/drivers/i2c/chips ; \
163		$(INSTALL) -~~o root -g root -~~m 644 $(KERNELCHIPSTARGETS) $(DESTDIR)$(MODPREF)/kernel/drivers/i2c/chips ; \
	163	$(INSTALL) -m 644 $(KERNELCHIPSTARGETS) $(DESTDIR)$(MODPREF)/kernel/drivers/i2c/chips ; \
164	164	for i in $(KERNELCHIPSTARGETS) ; do \
165	165	$(RM) $(DESTDIR)$(MODPREF)/misc/`basename $$i` $(DESTDIR)$(MODPREF)/kernel/drivers/sensors/`basename $$i` \

lm-sensors/trunk/kernel/include/Module.mk

r2085	r2189
40	40	if [ -n "$(KERNELINCLUDEFILES)" ] ; then \
41	41	$(MKDIR) $(DESTDIR)$(SYSINCLUDEDIR) ; \
42		$(INSTALL) -~~o root -g root -~~m 644 $(KERNELINCLUDEFILES) $(DESTDIR)$(SYSINCLUDEDIR) ; \
	42	$(INSTALL) -m 644 $(KERNELINCLUDEFILES) $(DESTDIR)$(SYSINCLUDEDIR) ; \
43	43	fi
44	44

lm-sensors/trunk/lib/Module.mk

r2163	r2189
111	111	echo '******************************************************************************' ; \
112	112	fi
113		$(INSTALL) -~~o root -g root -~~m 644 $(LIBTARGETS) $(DESTDIR)$(LIBDIR)
	113	$(INSTALL) -m 644 $(LIBTARGETS) $(DESTDIR)$(LIBDIR)
114	114	$(LN) $(LIBSHLIBNAME) $(DESTDIR)$(LIBDIR)/$(LIBSHSONAME)
115	115	$(LN) $(LIBSHSONAME) $(DESTDIR)$(LIBDIR)/$(LIBSHBASENAME)
…	…
133	133	echo '******************************************************************************' ) ; \
134	134	fi
135		$(INSTALL) -~~o root -g root -~~m 644 $(LIBHEADERFILES) $(DESTDIR)$(LIBINCLUDEDIR)
136		$(INSTALL) -~~o $(MANOWN) -g $(MANGRP) -~~m 644 $(LIBMAN3FILES) $(DESTDIR)$(LIBMAN3DIR)
137		$(INSTALL) -~~o $(MANOWN) -g $(MANGRP) -~~m 644 $(LIBMAN5FILES) $(DESTDIR)$(LIBMAN5DIR)
	135	$(INSTALL) -m 644 $(LIBHEADERFILES) $(DESTDIR)$(LIBINCLUDEDIR)
	136	$(INSTALL) -m 644 $(LIBMAN3FILES) $(DESTDIR)$(LIBMAN3DIR)
	137	$(INSTALL) -m 644 $(LIBMAN5FILES) $(DESTDIR)$(LIBMAN5DIR)
138	138
139	139

lm-sensors/trunk/prog/detect/Module.mk

r2185	r2189
40	40
41	41	install-prog-detect: all-prog-detect
42		~~mkdir -p~~ $(DESTDIR)$(SBINDIR)
43		$(INSTALL) -~~o root -g root -~~m 755 $(PROGDETECTSBININSTALL) $(DESTDIR)$(SBINDIR)
	42	$(MKDIR) $(DESTDIR)$(SBINDIR)
	43	$(INSTALL) -m 755 $(PROGDETECTSBININSTALL) $(DESTDIR)$(SBINDIR)
44	44	user_install :: install-prog-detect
45	45

lm-sensors/trunk/prog/dump/Module.mk

r2185	r2189
45	45
46	46	install-prog-dump: all-prog-dump
47		~~mkdir -p~~ $(DESTDIR)$(SBINDIR)
48		$(INSTALL) -~~o root -g root -~~m 755 $(PROGDUMPBININSTALL) $(DESTDIR)$(SBINDIR)
	47	$(MKDIR) $(DESTDIR)$(SBINDIR)
	48	$(INSTALL) -m 755 $(PROGDUMPBININSTALL) $(DESTDIR)$(SBINDIR)
49	49	user_install :: install-prog-dump
50	50

lm-sensors/trunk/prog/eeprom/Module.mk

r2164	r2189
25	25	install-prog-eeprom: $(PROGEEPROMTARGETS)
26	26	$(MKDIR) $(DESTDIR)$(BINDIR)
27		$(INSTALL) -~~o root -g root -~~m 755 $(PROGEEPROMTARGETS) $(DESTDIR)$(BINDIR)
	27	$(INSTALL) -m 755 $(PROGEEPROMTARGETS) $(DESTDIR)$(BINDIR)
28	28
29	29	user_install :: install-prog-eeprom

lm-sensors/trunk/prog/pwm/Module.mk

r2164	r2189
24	24	install-prog-pwm: $(PROGPWMTARGETS)
25	25	$(MKDIR) $(DESTDIR)$(SBINDIR)
26		$(INSTALL) -~~o root -g root -~~m 755 $(PROGPWMTARGETS) $(DESTDIR)$(SBINDIR)
	26	$(INSTALL) -m 755 $(PROGPWMTARGETS) $(DESTDIR)$(SBINDIR)
27	27
28	28	user_install :: install-prog-pwm

lm-sensors/trunk/prog/sensord/Module.mk

r2185	r2189
46	46	install-prog-sensord: all-prog-sensord
47	47	$(MKDIR) $(DESTDIR)$(SBINDIR) $(DESTDIR)$(PROGSENSORDMAN1DIR)
48		$(INSTALL) -~~o root -g root -~~m 755 $(PROGSENSORDTARGETS) $(DESTDIR)$(SBINDIR)
49		$(INSTALL) -~~o $(MANOWN) -g $(MANGRP) -~~m 644 $(PROGSENSORDMAN1FILES) $(DESTDIR)$(PROGSENSORDMAN1DIR)
	48	$(INSTALL) -m 755 $(PROGSENSORDTARGETS) $(DESTDIR)$(SBINDIR)
	49	$(INSTALL) -m 644 $(PROGSENSORDMAN1FILES) $(DESTDIR)$(PROGSENSORDMAN1DIR)
50	50	user_install :: install-prog-sensord
51	51

lm-sensors/trunk/prog/sensors/Module.mk

r2185	r2189
41	41
42	42	install-prog-sensors: all-prog-sensors
43		~~mkdir -p~~ $(DESTDIR)$(BINDIR) $(DESTDIR)$(PROGSENSORSMAN1DIR)
44		$(INSTALL) -~~o root -g root -~~m 755 $(PROGSENSORSTARGETS) $(DESTDIR)$(BINDIR)
45		$(INSTALL) -~~o $(MANOWN) -g $(MANGRP) -~~m 644 $(PROGSENSORSMAN1FILES) $(DESTDIR)$(PROGSENSORSMAN1DIR)
	43	$(MKDIR) $(DESTDIR)$(BINDIR) $(DESTDIR)$(PROGSENSORSMAN1DIR)
	44	$(INSTALL) -m 755 $(PROGSENSORSTARGETS) $(DESTDIR)$(BINDIR)
	45	$(INSTALL) -m 644 $(PROGSENSORSMAN1FILES) $(DESTDIR)$(PROGSENSORSMAN1DIR)
46	46	user_install :: install-prog-sensors
47	47

lm-sensors/trunk/prog/xeon/Module.mk

r2164	r2189
23	23	install-prog-xeon: $(PROGXEONTARGETS)
24	24	$(MKDIR) $(DESTDIR)$(BINDIR)
25		$(INSTALL) -~~o root -g root -~~m 755 $(PROGXEONTARGETS) $(DESTDIR)$(BINDIR)
	25	$(INSTALL) -m 755 $(PROGXEONTARGETS) $(DESTDIR)$(BINDIR)
26	26
27	27	user_install :: install-prog-xeon

Context Navigation

Changeset 2189

Legend:

Download in other formats: