Changeset 1404

Timestamp:

06/28/02 04:49:46 (11 years ago)

Author:

mds

Message:

add support for ICH4; patch from

Klaus Woltereck <kw42@…>

Location:

lm-sensors/trunk/prog/hotplug

Files:

• README (modified) (1 diff)
• README.p4b (modified) (3 diffs)
• p4b_smbus.c (modified) (10 diffs)

lm-sensors/trunk/prog/hotplug/README

@@ -1 +1 @@
 M7101 - SMBus Support for ALi M15x3 based motherboards.
+For Asus P4B motherboards, use the p4b_smbus module;
+see the file README.p4b.
 
 --------------------------------------------------------

lm-sensors/trunk/prog/hotplug/README.p4b

@@ -6 +6 @@
 It works by turning on the SMBus PCI device.
 It is implemented as a module, p4b_smbus.o.
+It only works with the ICH2 (82801BA) and ICH4 (82801DB).
 
-ASUS switches off the SMBus PCI Device in the i801 ICH2 chip. I spoke two times
+ASUS switches off the SMBus PCI Device
+in the i801 ICH2/4 chip. I spoke two times
 with the German support and learned that: "We do not want the users to be
 irritated by just another PCI Device in the Win98 device manager."
@@ -14 +16 @@
 What does the module do?
 ------------------------
+(Note: the following instructions assume the ICH2. For the ICH4,
+the PCI IDs are 24C0 and 24C3)
 
 It turnes off (!) the bits number 8 and 3 in the LPC register of the ICH2.
@@ -39 +43 @@
 ---------------------------------
 
-- Obviously a board with Intel i801BA ICH2 with broken bios.
+- Obviously a board with Intel i801BA/DB ICH2/4 with broken bios.
 - A linux working with a 2.4 kernel AND hotplug support in it! 
 - A installed kernel tree and gcc.

lm-sensors/trunk/prog/hotplug/p4b_smbus.c

@@ -5 +5 @@
  */
 /*
-    Copyright (c) 2002 Ilja Rauhut <IljaRauhut@web.de>,
+    Copyright (c) 2002 Ilja Rauhut <IljaRauhut@web.de> and
+    Klaus Woltereck <kw42@gmx.net>,
 
     Based on the m7101.c hotplug example by:
@@ -39 +40 @@
  * gcc > 2.7.2 or egcs >= 2.95.2. 
  *
+ *
+ * June 21, 2002, added support for the ICH4, code clean up -- Klaus
  */
 
@@ -85 +88 @@
 #define SMB_BASE 0x20
 
+
+/*
+ * some shorter definitions for the ICHx PCI device IDs
+ */
+
+#define ICH2 PCI_DEVICE_ID_INTEL_82801BA_0
+#define ICH2_SMBUS PCI_DEVICE_ID_INTEL_82801BA_3
+
+
+#ifndef PCI_DEVICE_ID_INTEL_82801DB_0
+#define PCI_DEVICE_ID_INTEL_82801DB_0 0x24c0
+#define PCI_DEVICE_ID_INTEL_82801DB_3 0x24c3
+#endif
+
+#define ICH4 PCI_DEVICE_ID_INTEL_82801DB_0
+#define ICH4_SMBUS PCI_DEVICE_ID_INTEL_82801DB_3
+
 /* status, used to indicate that io space needs to be freed */
 static struct pci_dev *i801smbus = NULL;
 static int i801smbus_inserted = FALSE;
-extern void cleanup_module();
+extern void cleanup_module(void);
  
 static rwlock_t i801smbus_lock = RW_LOCK_UNLOCKED;
@@ -95 +115 @@
 /* 
  * Checks whether SMBus is enabled and turns it on in case they are not. 
- * It's done by clearing Bit 8 and 4 in i801 config space F2h, PCI-Device 0x8086:0x2440
+ * It's done by clearing Bit 8 and 4 in i801 config space F2h, PCI-Device 0x8086:0x2440(ICH2)/0x24c0(ICH4)
  */
 static int
@@ -146 +166 @@
                 (*i801smbus)->devfn = devfn;
                 ret = pci_read_config_word(*i801smbus, PCI_DEVICE_ID, &id);
-                if (ret == 0 && 0x2443 == id) {
+                if (ret == 0 && (ICH2_SMBUS == id || ICH4_SMBUS == id)) {
                         pci_read_config_word(*i801smbus, PCI_VENDOR_ID, &vid);
                         if(vid == 0x8086)
@@ -152 +172 @@
                 }
         }
-        if (0x2443 != id) {     
+        if (!(ICH2_SMBUS == id || ICH4_SMBUS == id)) {  
                 DBG("i801smbus: i801smbus not found although i801 present - strange.\n");
                 return -EACCES;
@@ -164 +184 @@
         (*i801smbus)->vendor = 0x8086;
         (*i801smbus)->hdr_type = PCI_HEADER_TYPE_NORMAL;
-        (*i801smbus)->device = 0x2443;
+        (*i801smbus)->device = id;
  
         return(pci_setup_device(*i801smbus));
@@ -188 +208 @@
 
         /* We want to be sure that the i801smbus is not present yet. */
-        dev = pci_find_device(0x8086,0x2443, NULL);
+        dev = pci_find_device(0x8086, ICH2_SMBUS, NULL);
 
         if (dev) 
           {
-            printk("i801smbus: SMBus already actve\n");
+            printk("i801smbus: SMBus already active\n");
+            return -EPERM;
+          }
+        
+        dev = pci_find_device(0x8086, ICH4_SMBUS, NULL);
+
+        if (dev) 
+          {
+            printk("i801smbus: SMBus already active\n");
             return -EPERM;
           }
         
         /* Are we operating a i801 chipset */
-        dev = pci_find_device(0x8086,0x2440, NULL);
+        dev = pci_find_device(0x8086, ICH2, NULL);
         if (NULL == dev) 
           {
-            printk("INTEL ICH2 type 82801BA not found.\n");
-            return -ENODEV ;
-          }
+            dev = pci_find_device(0x8086, ICH4, NULL);
+            if (NULL == dev) 
+              {
+                printk("INTEL ICH2/4 (82801AB/DB) not found.\n");
+                return -ENODEV ;
+              }
+            else
+              {
+                printk("found Intel ICH4 (82801DB).\n");
+              }
+          }
+        else
+          {
+            printk("found Intel ICH2 (82801AB).\n");
+          }
+
         /* we need the bus pointer later */
         bus = dev->bus;
@@ -230 +271 @@
 
 
-void cleanup_module()
+void cleanup_module(void)
 {
         write_lock_irqsave(i801smbus_lock, i801smbus_lock_flags);
@@ -255 +296 @@
               "Burkhard Kohl <bku@buks.ipn.de>, "
               "Frank Bauer <frank.bauer@nikocity.de>, "
-              "and Mark Studebaker <mdsxyz123@yahoo.com>");
+              "Mark Studebaker <mdsxyz123@yahoo.com>,"
+              "and Klaus Woltereck <kw42@gmx.net>");
 MODULE_DESCRIPTION("i801smbus PCI Inserter");